Add string.Left/string.Right #25
Conversation
sarahsturgeon
left a comment
sarahsturgeon
left a comment
There was a problem hiding this comment.
Couple of updates to the expected err message! 🙏
|
Should be good now |
|
Weird batch of errors on the latest run, dunno why it's doing that |
|
Yeah that's really strange. I don't think there's anything else wrong with the test cases themselves as far as I can tell. Does it still do that even if the tests are run again? |
|
I think the error message just says |
|
Anything else I should do for this on my end? Changing the expected error messages to have |
RaphaelIT7
left a comment
RaphaelIT7
left a comment
There was a problem hiding this comment.
Looks good :D
the current issues with the error messages showing '?' are because of GLuaTest failing in your special case, in all other tests the errWith calls are not given directly the function that will error, instead they are are either wrapped in something like local testFunc = function(...) yourFunction(...) end or the error is thrown inside the function by another function that it uses inside of it.
In your case, you give expect directly to the function that throws the error, like string.Left with the nil argument, which hasn't been done before apparently and causes the error message to contain '?' as Lua loses track of the function you passed that is then called by pcall.
3 participants
Just a couple more string library tests I wrote up real quick while testing.